Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: Executing command to lorawan device should not change the path #442

Merged
merged 3 commits into from
Mar 11, 2022

Conversation

audserraCGI
Copy link
Contributor

@audserraCGI audserraCGI commented Mar 11, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@audserraCGI audserraCGI requested a review from a team as a code owner March 11, 2022 13:53
@audserraCGI audserraCGI linked an issue Mar 11, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #442 (7fa6889) into main (77dd6ee) will increase coverage by 0.05%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #442      +/-   ##
==========================================
+ Coverage   57.49%   57.55%   +0.05%     
==========================================
  Files         111      111              
  Lines        3294     3298       +4     
==========================================
+ Hits         1894     1898       +4     
  Misses       1400     1400              
Impacted Files Coverage Δ
.../Client/Pages/Devices/LoRaWAN/EditLoraDevice.razor 0.00% <0.00%> (ø)
...ntrollers/v1.0/LoRaWAN/LoRaWANDevicesController.cs 100.00% <100.00%> (ø)
...reIoTHub.Portal/Server/Mappers/DeviceTwinMapper.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77dd6ee...7fa6889. Read the comment docs.

@audserraCGI audserraCGI merged commit 54f66e0 into main Mar 11, 2022
@audserraCGI audserraCGI deleted the 436_fix_path_change branch March 11, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Executing command to lorawan device should not change the path
2 participants