Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change device model properties design #446

Merged
merged 6 commits into from
Mar 12, 2022

Conversation

Sben65
Copy link
Contributor

@Sben65 Sben65 commented Mar 11, 2022

Description

What's new?

  • changing the design of deviceModel Creation Page and edit DeviceModel Page.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@Sben65 Sben65 requested a review from a team as a code owner March 11, 2022 15:40
@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #446 (37196e8) into main (300b7b1) will decrease coverage by 0.79%.
The diff coverage is 38.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #446      +/-   ##
==========================================
- Coverage   57.62%   56.82%   -0.80%     
==========================================
  Files         112      112              
  Lines        3299     3340      +41     
==========================================
- Hits         1901     1898       -3     
- Misses       1398     1442      +44     
Impacted Files Coverage Δ
...tal/Client/Pages/Configurations/ConfigDetail.razor 0.00% <ø> (ø)
...b.Portal/Client/Pages/Configurations/Configs.razor 0.00% <ø> (ø)
...tal/Client/Pages/Configurations/ModuleDetail.razor 0.00% <ø> (ø)
...ent/Pages/DeviceModels/CreateDeviceModelPage.razor 54.74% <ø> (ø)
...ent/Pages/DeviceModels/DeleteDeviceModelPage.razor 0.00% <ø> (ø)
...ent/Pages/DeviceModels/DeviceModelDetailPage.razor 61.78% <ø> (ø)
...lient/Pages/DeviceModels/DeviceModelListPage.razor 47.05% <ø> (ø)
...s/DeviceModels/LoRaWAN/CreateLoraDeviceModel.razor 0.00% <0.00%> (ø)
...ges/DeviceModels/LoRaWAN/EditLoraDeviceModel.razor 0.00% <0.00%> (ø)
.../Client/Pages/Devices/ConnectionStringDialog.razor 0.00% <ø> (ø)
... and 78 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 300b7b1...37196e8. Read the comment docs.

@kbeaugrand kbeaugrand force-pushed the change_device_model_properties_design branch 2 times, most recently from 8fc562b to 30ba542 Compare March 11, 2022 20:30
@kbeaugrand kbeaugrand force-pushed the change_device_model_properties_design branch from 30ba542 to f1a5329 Compare March 12, 2022 12:09
@kbeaugrand kbeaugrand merged commit 2780adc into main Mar 12, 2022
@kbeaugrand kbeaugrand deleted the change_device_model_properties_design branch March 12, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants