Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #387 - Add portal name setting #449

Merged
merged 1 commit into from
Mar 11, 2022

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Mar 11, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand requested a review from a team as a code owner March 11, 2022 18:53
@kbeaugrand kbeaugrand force-pushed the ffix/387_add_portal_name_setting branch from 5738e14 to ea24814 Compare March 11, 2022 18:53
@kbeaugrand kbeaugrand force-pushed the ffix/387_add_portal_name_setting branch from ea24814 to a5ff4ae Compare March 11, 2022 19:12
@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #449 (a5ff4ae) into main (6f03b07) will increase coverage by 0.08%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #449      +/-   ##
==========================================
+ Coverage   57.55%   57.63%   +0.08%     
==========================================
  Files         111      112       +1     
  Lines        3298     3300       +2     
==========================================
+ Hits         1898     1902       +4     
+ Misses       1400     1398       -2     
Impacted Files Coverage Δ
...b.Portal/Client/Pages/Devices/DeviceListPage.razor 61.53% <ø> (-0.42%) ⬇️
.../AzureIoTHub.Portal/Client/Shared/MainLayout.razor 0.00% <0.00%> (ø)
src/AzureIoTHub.Portal/Client/Shared/NavMenu.razor 0.00% <0.00%> (ø)
...ent/Pages/DeviceModels/CreateDeviceModelPage.razor 54.74% <100.00%> (-0.97%) ⬇️
...rtal/Server/Controllers/v1.0/SettingsController.cs 100.00% <100.00%> (+21.42%) ⬆️
...IoTHub.Portal/Shared/Models/v1.0/PortalSettings.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f03b07...a5ff4ae. Read the comment docs.

@kbeaugrand kbeaugrand merged commit fd9a56b into main Mar 11, 2022
@kbeaugrand kbeaugrand deleted the ffix/387_add_portal_name_setting branch March 11, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant