Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Device Model list page loading since portal settings changes #452

Merged
merged 1 commit into from
Mar 12, 2022

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Mar 12, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand requested a review from a team as a code owner March 12, 2022 09:20
@kbeaugrand kbeaugrand linked an issue Mar 12, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Mar 12, 2022

Codecov Report

Merging #452 (d6512aa) into main (fd9a56b) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #452      +/-   ##
==========================================
- Coverage   57.63%   57.62%   -0.02%     
==========================================
  Files         112      112              
  Lines        3300     3299       -1     
==========================================
- Hits         1902     1901       -1     
  Misses       1398     1398              
Impacted Files Coverage Δ
...lient/Pages/DeviceModels/DeviceModelListPage.razor 47.05% <100.00%> (-1.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd9a56b...d6512aa. Read the comment docs.

@kbeaugrand kbeaugrand merged commit 300b7b1 into main Mar 12, 2022
@kbeaugrand kbeaugrand deleted the fix/device_list_not_load_lora_setting branch March 12, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Device model list page failed to load
1 participant