Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add device custom properties management #457

Merged
merged 4 commits into from
Mar 14, 2022

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Mar 14, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand requested a review from a team as a code owner March 14, 2022 10:49
@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #457 (396280e) into main (d029446) will increase coverage by 0.10%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #457      +/-   ##
==========================================
+ Coverage   57.15%   57.26%   +0.10%     
==========================================
  Files         111      114       +3     
  Lines        3338     3470     +132     
==========================================
+ Hits         1908     1987      +79     
- Misses       1430     1483      +53     
Impacted Files Coverage Δ
...Portal/Client/Pages/Devices/CreateDevicePage.razor 0.00% <0.00%> (ø)
...Portal/Client/Pages/Devices/DeviceDetailPage.razor 0.00% <0.00%> (ø)
...THub.Portal/Server/Entities/DeviceModelProperty.cs 80.00% <0.00%> (+55.00%) ⬆️
...ub.Portal/Client/Extensions/EnumerableExtension.cs 83.33% <83.33%> (ø)
...ortal/Server/Controllers/v1.0/DevicesController.cs 96.29% <95.00%> (-3.71%) ⬇️
....Portal/Client/Converters/StringToBoolConverter.cs 100.00% <100.00%> (ø)
...ent/Pages/DeviceModels/CreateDeviceModelPage.razor 68.34% <100.00%> (ø)
...ent/Pages/DeviceModels/DeviceModelDetailPage.razor 62.69% <100.00%> (ø)
...l/Shared/Models/v1.0/Device/DevicePropertyValue.cs 100.00% <100.00%> (ø)
...IoTHub.Portal/Shared/Models/v1.0/DeviceProperty.cs 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d029446...396280e. Read the comment docs.

@kbeaugrand kbeaugrand merged commit 6604e17 into main Mar 14, 2022
@kbeaugrand kbeaugrand deleted the feature/add_device_custom_properties_management branch March 14, 2022 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant