Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #424 - display device name in screens instead of device id #463

Merged
merged 1 commit into from
Mar 16, 2022

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Mar 16, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand requested a review from a team as a code owner March 16, 2022 10:34
@kbeaugrand kbeaugrand linked an issue Mar 16, 2022 that may be closed by this pull request
2 tasks
@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #463 (5b62c06) into main (9055acd) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #463      +/-   ##
==========================================
- Coverage   59.03%   58.98%   -0.05%     
==========================================
  Files         113      113              
  Lines        3586     3589       +3     
==========================================
  Hits         2117     2117              
- Misses       1469     1472       +3     
Impacted Files Coverage Δ
...Portal/Client/Pages/Devices/CreateDevicePage.razor 0.00% <0.00%> (ø)
...Portal/Client/Pages/Devices/DeleteDevicePage.razor 0.00% <0.00%> (ø)
...Portal/Client/Pages/Devices/DeviceDetailPage.razor 0.00% <0.00%> (ø)
...b.Portal/Client/Pages/Devices/DeviceListPage.razor 61.53% <0.00%> (-1.62%) ⬇️
...e_Devices/EdgeDeviceDeleteConfirmationDialog.razor 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9055acd...5b62c06. Read the comment docs.

@kbeaugrand kbeaugrand merged commit 0048561 into main Mar 16, 2022
@kbeaugrand kbeaugrand deleted the fix/424_display_device_name_instead_of_id branch March 16, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: display Device name instead of device id
1 participant