Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/447 add scope id configuration to portal #469

Merged
merged 3 commits into from
Mar 22, 2022
Merged

Fix/447 add scope id configuration to portal #469

merged 3 commits into from
Mar 22, 2022

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Mar 21, 2022 •
edited
Loading

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand requested a review from a team as a code owner March 21, 2022 09:50
@codecov
Copy link

codecov bot commented Mar 21, 2022 •
edited
Loading

Codecov Report

Merging #469 (8e7748f) into main (bd16055) will increase coverage by 0.99%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #469      +/-   ##
==========================================
+ Coverage   59.00%   60.00%   +0.99%     
==========================================
  Files         114      114              
  Lines        3688     3690       +2     
==========================================
+ Hits         2176     2214      +38     
+ Misses       1512     1476      -36
Impacted Files Coverage Δ
src/AzureIoTHub.Portal/Server/ConfigHandler.cs 0.00% <ø> (ø)
...reIoTHub.Portal/Server/DevelopmentConfigHandler.cs 100.00% <100.00%> (+80.00%) ⬆️
...ureIoTHub.Portal/Server/ProductionConfigHandler.cs 100.00% <100.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd16055...8e7748f. Read the comment docs.

@kbeaugrand kbeaugrand force-pushed the fix/447_add_scope_id_configuration_to_portal branch from 3a41566 to 8e7748f Compare March 21, 2022 16:21
@kbeaugrand kbeaugrand merged commit 89d69c8 into main Mar 22, 2022
@kbeaugrand kbeaugrand deleted the fix/447_add_scope_id_configuration_to_portal branch March 22, 2022 08:25
kbeaugrand added a commit that referenced this pull request Mar 22, 2022
@kbeaugrand
Fix/447 add scope id configuration to portal (#469)
cd29c6a 
* Add ID scope to portal deployment template

* Read DPS Scope ID from Settings

* Add unit tests coverage to config handlers
kbeaugrand added a commit that referenced this pull request Mar 22, 2022
@kbeaugrand
Fix/447 add scope id configuration to portal (#469) (#473)
b03b7df 
* Add ID scope to portal deployment template

* Read DPS Scope ID from Settings

* Add unit tests coverage to config handlers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@audserraCGI audserraCGI audserraCGI approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Add IoT Edge device Scope ID in connection information
2 participants
@kbeaugrand @audserraCGI