Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add 'https://' before dps service endpoint #471

Merged
merged 2 commits into from
Mar 22, 2022

Conversation

ChristopheRib63
Copy link
Contributor

@ChristopheRib63 ChristopheRib63 commented Mar 22, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@ChristopheRib63 ChristopheRib63 requested a review from a team as a code owner March 22, 2022 08:40
@kbeaugrand kbeaugrand changed the title add https on DPS Feature: Add 'https://' before dps service endpoint Mar 22, 2022
@kbeaugrand kbeaugrand force-pushed the feature/468_add_https branch from 81fc4ba to 43da25b Compare March 22, 2022 09:12
@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #471 (d6c0781) into main (80e727d) will not change coverage.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main     #471   +/-   ##
=======================================
  Coverage   60.08%   60.08%           
=======================================
  Files         114      114           
  Lines        3685     3685           
=======================================
  Hits         2214     2214           
  Misses       1471     1471           
Impacted Files Coverage Δ
...nt/Pages/Edge_Devices/ConnectionStringDialog.razor 0.00% <0.00%> (ø)
...erver/Managers/DeviceProvisioningServiceManager.cs 92.85% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80e727d...d6c0781. Read the comment docs.

@kbeaugrand kbeaugrand merged commit 882c0b7 into main Mar 22, 2022
@kbeaugrand kbeaugrand deleted the feature/468_add_https branch March 22, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add 'https://' before dps service endpoint
2 participants