Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #371 - Add portal name to page title #472

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Mar 22, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand requested a review from a team as a code owner March 22, 2022 08:53
@kbeaugrand kbeaugrand force-pushed the fix/371_add_portal_name_to_page_title branch from 7f87d32 to 89ad81b Compare March 22, 2022 08:56
@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #472 (2d4c5c3) into main (b03b7df) will increase coverage by 0.08%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #472      +/-   ##
==========================================
+ Coverage   60.00%   60.08%   +0.08%     
==========================================
  Files         114      114              
  Lines        3690     3685       -5     
==========================================
  Hits         2214     2214              
+ Misses       1476     1471       -5     
Impacted Files Coverage Δ
.../AzureIoTHub.Portal/Client/Shared/MainLayout.razor 0.00% <0.00%> (ø)
src/AzureIoTHub.Portal/Server/ConfigHandler.cs 0.00% <ø> (ø)
...rtal/Server/Controllers/v1.0/SettingsController.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b03b7df...2d4c5c3. Read the comment docs.

@kbeaugrand kbeaugrand force-pushed the fix/371_add_portal_name_to_page_title branch from 89ad81b to 2d4c5c3 Compare March 22, 2022 09:00
@kbeaugrand kbeaugrand merged commit 80e727d into main Mar 22, 2022
@kbeaugrand kbeaugrand deleted the fix/371_add_portal_name_to_page_title branch March 22, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: Add Custom Site Title + Header (in the browser title)
1 participant