Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual changes on device details #474

Merged
merged 6 commits into from
Mar 22, 2022

Conversation

audserraCGI
Copy link
Contributor

@audserraCGI audserraCGI commented Mar 22, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@audserraCGI audserraCGI requested a review from a team as a code owner March 22, 2022 10:43
@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #474 (b76ad4e) into main (882c0b7) will increase coverage by 0.44%.
The diff coverage is 28.37%.

@@            Coverage Diff             @@
##             main     #474      +/-   ##
==========================================
+ Coverage   60.08%   60.52%   +0.44%     
==========================================
  Files         114      114              
  Lines        3685     3701      +16     
==========================================
+ Hits         2214     2240      +26     
+ Misses       1471     1461      -10     
Impacted Files Coverage Δ
...Portal/Client/Pages/Devices/DeviceDetailPage.razor 0.00% <0.00%> (ø)
...lient/Pages/Devices/LoRaWAN/CreateLoraDevice.razor 0.00% <ø> (ø)
.../Client/Pages/Devices/LoRaWAN/EditLoraDevice.razor 0.00% <0.00%> (ø)
...b.Portal/Client/Pages/Devices/DeviceListPage.razor 61.53% <100.00%> (ø)
...al/Client/Validators/LoRaDeviceDetailsValidator.cs 100.00% <100.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 882c0b7...b76ad4e. Read the comment docs.

@kbeaugrand kbeaugrand merged commit 4fd449f into main Mar 22, 2022
@kbeaugrand kbeaugrand deleted the 425_visual_changes_on_device_details branch March 22, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants