Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #475 - Remove redundant call to ToString() in Device Service #476

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Mar 22, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand requested a review from a team as a code owner March 22, 2022 12:52
@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #476 (7070bdd) into main (4fd449f) will decrease coverage by 0.44%.
The diff coverage is 100.00%.

❗ Current head 7070bdd differs from pull request most recent head d98ed27. Consider uploading reports for the commit d98ed27 to get more accurate results

@@            Coverage Diff             @@
##             main     #476      +/-   ##
==========================================
- Coverage   60.52%   60.08%   -0.45%     
==========================================
  Files         114      114              
  Lines        3701     3685      -16     
==========================================
- Hits         2240     2214      -26     
- Misses       1461     1471      +10     
Impacted Files Coverage Δ
...zureIoTHub.Portal/Server/Services/DeviceService.cs 90.60% <100.00%> (ø)
...al/Client/Validators/LoRaDeviceDetailsValidator.cs 0.00% <0.00%> (-100.00%) ⬇️
...Portal/Client/Pages/Devices/DeviceDetailPage.razor 0.00% <0.00%> (ø)
.../Client/Pages/Devices/LoRaWAN/EditLoraDevice.razor 0.00% <0.00%> (ø)
...lient/Pages/Devices/LoRaWAN/CreateLoraDevice.razor 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fd449f...d98ed27. Read the comment docs.

@kbeaugrand kbeaugrand force-pushed the fix/475_remove_redundant_call_to_tostring branch from 7070bdd to d98ed27 Compare March 22, 2022 15:22
@kbeaugrand kbeaugrand merged commit 5541bb3 into main Mar 22, 2022
@kbeaugrand kbeaugrand deleted the fix/475_remove_redundant_call_to_tostring branch March 22, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix code scanning alert - Redundant ToString() call
1 participant