Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rearrange "+" buttons in list screens #478

Merged
merged 4 commits into from
Mar 26, 2022
Merged

Rearrange "+" buttons in list screens #478

merged 4 commits into from
Mar 26, 2022

Conversation

ChristopheRib63
Copy link
Contributor

@ChristopheRib63 ChristopheRib63 commented Mar 23, 2022 •
edited by kbeaugrand
Loading

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@ChristopheRib63 ChristopheRib63 requested a review from a team as a code owner March 23, 2022 15:38
@kbeaugrand kbeaugrand force-pushed the feature/421_rearrange_+ branch 2 times, most recently from 23d09f2 to 2341abd Compare March 24, 2022 13:09
@ChristopheRib63 ChristopheRib63 force-pushed the feature/421_rearrange_+ branch from 2341abd to 292361b Compare March 24, 2022 14:26
@codecov
Copy link

codecov bot commented Mar 24, 2022 •
edited
Loading

Codecov Report

Merging #478 (3f5ce61) into main (38b4442) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #478   +/-   ##
=======================================
  Coverage   60.75%   60.75%           
=======================================
  Files         114      114           
  Lines        3710     3710           
=======================================
  Hits         2254     2254           
  Misses       1456     1456
Impacted Files Coverage Δ
...lient/Pages/DeviceModels/DeviceModelListPage.razor 47.05% <ø> (ø)
...Portal/Client/Pages/Devices/DeviceDetailPage.razor 0.00% <ø> (ø)
...b.Portal/Client/Pages/Devices/DeviceListPage.razor 61.53% <ø> (ø)
...Client/Pages/Edge_Devices/EdgeDeviceListPage.razor 0.00% <ø> (ø)
...es/LoRaWAN/Concentrator/ConcentratorListPage.razor 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38b4442...3f5ce61. Read the comment docs.

@ChristopheRib63
Copy link
Contributor Author

image

@kbeaugrand kbeaugrand changed the title Rearrange + Rearrange "+" buttons in list screens Mar 25, 2022
@kbeaugrand kbeaugrand self-requested a review March 25, 2022 16:49
@kbeaugrand kbeaugrand force-pushed the feature/421_rearrange_+ branch from c83b448 to 3f5ce61 Compare March 25, 2022 16:51
@kbeaugrand kbeaugrand merged commit 20bb502 into main Mar 26, 2022
@kbeaugrand kbeaugrand deleted the feature/421_rearrange_+ branch March 26, 2022 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbeaugrand kbeaugrand kbeaugrand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Task: Rearrange "+" buttons in list screens
2 participants
@ChristopheRib63 @kbeaugrand