Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual changes on device create #480

Merged
merged 5 commits into from
Mar 24, 2022
Merged

Conversation

audserraCGI
Copy link
Contributor

@audserraCGI audserraCGI commented Mar 23, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@audserraCGI audserraCGI requested a review from a team as a code owner March 23, 2022 15:55
@kbeaugrand kbeaugrand force-pushed the 425_visual_changes_on_device_create branch from de530f9 to 91a69c6 Compare March 24, 2022 09:32
@codecov
Copy link

codecov bot commented Mar 24, 2022

Codecov Report

Merging #480 (91a69c6) into main (5f38e42) will increase coverage by 0.22%.
The diff coverage is 13.79%.

@@            Coverage Diff             @@
##             main     #480      +/-   ##
==========================================
+ Coverage   60.52%   60.75%   +0.22%     
==========================================
  Files         114      114              
  Lines        3704     3710       +6     
==========================================
+ Hits         2242     2254      +12     
+ Misses       1462     1456       -6     
Impacted Files Coverage Δ
...Portal/Client/Pages/Devices/CreateDevicePage.razor 0.00% <0.00%> (ø)
...Portal/Client/Pages/Devices/DeviceDetailPage.razor 0.00% <0.00%> (ø)
...lient/Pages/Devices/LoRaWAN/CreateLoraDevice.razor 0.00% <0.00%> (ø)
...Portal/Client/Validators/DeviceDetailsValidator.cs 100.00% <100.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f38e42...91a69c6. Read the comment docs.

@audserraCGI audserraCGI changed the title WIP : Visual changes on device create Visual changes on device create Mar 24, 2022
@kbeaugrand kbeaugrand merged commit 7766068 into main Mar 24, 2022
@kbeaugrand kbeaugrand deleted the 425_visual_changes_on_device_create branch March 24, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants