Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #483 - Rename fields in connection screens #493

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Mar 27, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand requested a review from a team as a code owner March 27, 2022 07:44
@codecov
Copy link

codecov bot commented Mar 27, 2022

Codecov Report

Merging #493 (8108946) into main (a7ae833) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #493   +/-   ##
=======================================
  Coverage   60.75%   60.75%           
=======================================
  Files         114      114           
  Lines        3710     3710           
=======================================
  Hits         2254     2254           
  Misses       1456     1456           
Impacted Files Coverage Δ
.../Client/Pages/Devices/ConnectionStringDialog.razor 0.00% <ø> (ø)
...nt/Pages/Edge_Devices/ConnectionStringDialog.razor 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7ae833...8108946. Read the comment docs.

@kbeaugrand kbeaugrand self-assigned this Mar 27, 2022
@kbeaugrand kbeaugrand force-pushed the fix/483_rename_deviceID_to_registrationID_in-_connection_screens branch from 3d010a7 to 8108946 Compare March 27, 2022 10:24
@kbeaugrand kbeaugrand merged commit 60dad53 into main Mar 27, 2022
@kbeaugrand kbeaugrand deleted the fix/483_rename_deviceID_to_registrationID_in-_connection_screens branch March 27, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: rename deviceID to registrationID in connect popup
1 participant