Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #488 - Use model id in twin configuration names #497

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Mar 28, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand requested a review from a team as a code owner March 28, 2022 13:08
@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #497 (f56106d) into main (51bba13) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #497   +/-   ##
=======================================
  Coverage   60.39%   60.39%           
=======================================
  Files         114      114           
  Lines        3729     3729           
=======================================
  Hits         2252     2252           
  Misses       1477     1477           
Impacted Files Coverage Δ
...rver/Controllers/v1.0/DeviceModelControllerBase.cs 85.71% <100.00%> (ø)
...zureIoTHub.Portal/Server/Services/ConfigService.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51bba13...f56106d. Read the comment docs.

@kbeaugrand kbeaugrand merged commit 291c51b into main Mar 28, 2022
@kbeaugrand kbeaugrand deleted the fix/488_use_model_id_in_configuration branch March 28, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Error while updating device models
2 participants