Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/879 Add a creation/modification dialog for edge modules #896

Merged
merged 9 commits into from
Jul 20, 2022

Conversation

audserraCGI
Copy link
Contributor

@audserraCGI audserraCGI commented Jul 1, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@audserraCGI audserraCGI force-pushed the 879_edge_modules_page branch 2 times, most recently from f9c1582 to e7d19f8 Compare July 18, 2022 13:42
@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #896 (8016974) into main (f14be8a) will increase coverage by 0.44%.
The diff coverage is 90.58%.

@@            Coverage Diff             @@
##             main     #896      +/-   ##
==========================================
+ Coverage   83.91%   84.36%   +0.44%     
==========================================
  Files         168      174       +6     
  Lines        5575     5633      +58     
==========================================
+ Hits         4678     4752      +74     
+ Misses        897      881      -16     
Impacted Files Coverage Δ
....Portal/Client/Pages/EdgeModels/ConfigDetail.razor 60.86% <0.00%> (ø)
.../AzureIoTHub.Portal/Server/Helpers/ConfigHelper.cs 86.99% <50.00%> (-3.28%) ⬇️
...ent/Pages/EdgeModels/EdgeModule/ModuleDialog.razor 100.00% <100.00%> (ø)
...Pages/EdgeModels/EdgeModule/ModuleDialogTab1.razor 100.00% <100.00%> (ø)
...Pages/EdgeModels/EdgeModule/ModuleDialogTab2.razor 100.00% <100.00%> (ø)
...Pages/EdgeModels/EdgeModule/ModuleDialogTab3.razor 100.00% <100.00%> (ø)
...eIoTHub.Portal/Shared/Models/v1.0/IoTEdgeModule.cs 100.00% <100.00%> (ø)
....Portal/Shared/Models/v1.0/IoTEdgeModuleCommand.cs 100.00% <100.00%> (ø)
...ed/Models/v1.0/IoTEdgeModuleEnvironmentVariable.cs 100.00% <100.00%> (ø)
...tal/Shared/Models/v1.0/IoTEdgeModuleTwinSetting.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f14be8a...8016974. Read the comment docs.

@audserraCGI audserraCGI marked this pull request as ready for review July 20, 2022 07:09
@audserraCGI audserraCGI requested a review from a team as a code owner July 20, 2022 07:09
@audserraCGI audserraCGI force-pushed the 879_edge_modules_page branch from d57a75c to 8016974 Compare July 20, 2022 07:11
@kbeaugrand kbeaugrand self-requested a review July 20, 2022 09:45
@kbeaugrand kbeaugrand merged commit a9a1f66 into main Jul 20, 2022
@kbeaugrand kbeaugrand deleted the 879_edge_modules_page branch July 20, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants