Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation issue on DeviceID when creating a new LoRa Device #917

Merged
merged 2 commits into from
Jul 18, 2022

Conversation

ChristopheRib63
Copy link
Contributor

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix

@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #917 (dd7ec84) into main (bae9886) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #917      +/-   ##
==========================================
+ Coverage   83.84%   83.88%   +0.04%     
==========================================
  Files         167      167              
  Lines        5552     5566      +14     
==========================================
+ Hits         4655     4669      +14     
  Misses        897      897              
Impacted Files Coverage Δ
...Portal/Client/Pages/Devices/CreateDevicePage.razor 66.27% <ø> (ø)
...al/Client/Validators/LoRaDeviceDetailsValidator.cs 100.00% <ø> (ø)
...Portal/Client/Validators/DeviceDetailsValidator.cs 100.00% <100.00%> (ø)
...eIoTHub.Portal/Shared/Models/v1.0/DeviceDetails.cs 100.00% <100.00%> (ø)
...al/Shared/Models/v1.0/LoRaWAN/LoRaDeviceDetails.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bae9886...dd7ec84. Read the comment docs.

@ChristopheRib63 ChristopheRib63 force-pushed the bug/842_Issue_on_validation branch from 45da3d7 to 2030a00 Compare July 13, 2022 14:31
@audserraCGI audserraCGI force-pushed the bug/842_Issue_on_validation branch from 95f2c54 to dd7ec84 Compare July 18, 2022 09:00
@audserraCGI audserraCGI marked this pull request as ready for review July 18, 2022 09:09
@audserraCGI audserraCGI requested a review from a team as a code owner July 18, 2022 09:09
@audserraCGI audserraCGI changed the title Modification validator Fix validation issue on DeviceID when creating a new LoRa Device Jul 18, 2022
@kbeaugrand kbeaugrand merged commit 373d45c into main Jul 18, 2022
@kbeaugrand kbeaugrand deleted the bug/842_Issue_on_validation branch July 18, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants