Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a RegexMask on command frame to prevent non-hexadecimal characters #949

Merged
merged 7 commits into from
Jul 21, 2022

Conversation

audserraCGI
Copy link
Contributor

@audserraCGI audserraCGI commented Jul 20, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #949 (4a2df0c) into main (e7eac9a) will increase coverage by 1.46%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #949      +/-   ##
==========================================
+ Coverage   84.36%   85.82%   +1.46%     
==========================================
  Files         174      174              
  Lines        5633     5635       +2     
==========================================
+ Hits         4752     4836      +84     
+ Misses        881      799      -82     
Impacted Files Coverage Δ
...l/Shared/Models/v1.0/LoRaWAN/DeviceModelCommand.cs 100.00% <ø> (ø)
...s/DeviceModels/LoRaWAN/CreateLoraDeviceModel.razor 93.18% <100.00%> (+93.18%) ⬆️
...ges/DeviceModels/LoRaWAN/EditLoraDeviceModel.razor 95.55% <100.00%> (+95.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7eac9a...4a2df0c. Read the comment docs.

@audserraCGI audserraCGI force-pushed the bug/914_non-hexadecimal_characters_in_command_frame branch from 3f7c57b to 13f6cc8 Compare July 20, 2022 11:43
@audserraCGI audserraCGI force-pushed the bug/914_non-hexadecimal_characters_in_command_frame branch from d32ab4d to ad40344 Compare July 20, 2022 14:31
@audserraCGI audserraCGI marked this pull request as ready for review July 20, 2022 15:30
@audserraCGI audserraCGI requested a review from a team as a code owner July 20, 2022 15:30
Copy link
Member

@kbeaugrand kbeaugrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also add Validation to the DeviceModelCommand to validate the input by the API too

@audserraCGI audserraCGI requested a review from kbeaugrand July 21, 2022 08:09
@audserraCGI audserraCGI requested a review from kbeaugrand July 21, 2022 08:31
@kbeaugrand kbeaugrand merged commit 32240c1 into main Jul 21, 2022
@kbeaugrand kbeaugrand deleted the bug/914_non-hexadecimal_characters_in_command_frame branch July 21, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants