Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize LoRaDeviceModelBase and LoRaDeviceModel models #971

Merged
merged 2 commits into from
Jul 25, 2022

Conversation

audserraCGI
Copy link
Contributor

@audserraCGI audserraCGI commented Jul 25, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #971 (9389b98) into main (2d9b3ca) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

❗ Current head 9389b98 differs from pull request most recent head 5405c26. Consider uploading reports for the commit 5405c26 to get more accurate results

@@            Coverage Diff             @@
##             main     #971      +/-   ##
==========================================
- Coverage   85.95%   85.88%   -0.07%     
==========================================
  Files         172      171       -1     
  Lines        5603     5597       -6     
==========================================
- Hits         4816     4807       -9     
- Misses        787      790       +3     
Impacted Files Coverage Δ
...Hub.Portal/Server/Mappers/LoRaDeviceModelMapper.cs 100.00% <100.00%> (ø)
...rtal/Shared/Models/v1.0/LoRaWAN/LoRaDeviceModel.cs 100.00% <100.00%> (ø)
...es/LoRaWAN/Concentrator/ConcentratorListPage.razor 58.62% <0.00%> (-5.18%) ⬇️
...ers/v1.0/LoRaWAN/LoRaWANConcentratorsController.cs 89.74% <0.00%> (-0.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d9b3ca...5405c26. Read the comment docs.

@audserraCGI audserraCGI marked this pull request as ready for review July 25, 2022 14:44
@audserraCGI audserraCGI requested a review from a team as a code owner July 25, 2022 14:44
@kbeaugrand kbeaugrand merged commit 8c68d57 into main Jul 25, 2022
@kbeaugrand kbeaugrand deleted the 970_reorganize_loradevicemodel_models branch July 25, 2022 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Reorganize LoRaDeviceModelBase and LoRaDeviceModel models
2 participants