Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor LoraWanCommandsController #996

Merged
merged 3 commits into from
Jul 29, 2022

Conversation

audserraCGI
Copy link
Contributor

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@audserraCGI audserraCGI force-pushed the 979_refactor_LoRaWanCommandsController branch from 3b8e3f9 to 14943db Compare July 28, 2022 15:03
@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #996 (b0eb129) into main (ae61dd1) will increase coverage by 0.02%.
The diff coverage is 97.46%.

@@            Coverage Diff             @@
##             main     #996      +/-   ##
==========================================
+ Coverage   85.94%   85.97%   +0.02%     
==========================================
  Files         171      172       +1     
  Lines        5600     5597       -3     
==========================================
- Hits         4813     4812       -1     
+ Misses        787      785       -2     
Impacted Files Coverage Δ
...ub.Portal/Server/Services/LoRaWANCommandService.cs 97.26% <97.26%> (ø)
...trollers/v1.0/LoRaWAN/LoRaWANCommandsController.cs 100.00% <100.00%> (+4.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae61dd1...b0eb129. Read the comment docs.

@audserraCGI audserraCGI marked this pull request as ready for review July 29, 2022 07:41
@audserraCGI audserraCGI requested a review from a team as a code owner July 29, 2022 07:41
@hocinehacherouf hocinehacherouf merged commit 526b04e into main Jul 29, 2022
@hocinehacherouf hocinehacherouf deleted the 979_refactor_LoRaWanCommandsController branch July 29, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor LoraWanCommandsController
2 participants