Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/explore: Markers don't appear when zoomed out to world scale #17

Open
rsargent opened this issue Dec 5, 2020 · 3 comments
Open

/explore: Markers don't appear when zoomed out to world scale #17

rsargent opened this issue Dec 5, 2020 · 3 comments

Comments

@rsargent
Copy link
Member

rsargent commented Dec 5, 2020

More precisely, if the width is more than 360 degrees of longitude?

https://environmentaldata.org/#time=1606562250.922,1607167050.922&cursor=1607167050.922&plotHeight=5.000&plotAreaHeight=20.000&showFilters=true&showSettings=true&showResults=true&center=41.617318807058865,-0.5188805651700168&zoom=1

doesn't show at 915 pixels wide:
image

but does show at 905 pixels wide:
image

@dognotdog
Copy link
Contributor

@rsargent this is a difficult thing because of the way the Google Maps layer reports visible coordinates when zoomed out super far. /browse has a half-working impl to place a single set of markers, but I feel like that is not quite the right solution.

Ideally, we would draw markers on all visible earth copies, but that requires some careful plumbing work.

@rsargent
Copy link
Member Author

rsargent commented Dec 5, 2020 via email

@dognotdog
Copy link
Contributor

@rsargent which is what /browse attempts, but I've found that impl to be broken, unfortunately :(

@dognotdog dognotdog transferred this issue from CMU-CREATE-Lab/esdr Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants