Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/explore map overlay coordinate conversions cleanup #22

Open
dognotdog opened this issue Dec 5, 2020 · 0 comments
Open

/explore map overlay coordinate conversions cleanup #22

dognotdog opened this issue Dec 5, 2020 · 0 comments

Comments

@dognotdog
Copy link
Contributor

The map overlay has a bunch of coordinate conversions functions between pixels and CSS/canvas pixels, and convenience functions that support the operations needed for UI and display.

These have some inconsistency in terms of using CSS/canvas coordinates, and wether google.maps.LatLng objects are accepted and returned or simple {lat,lng} objects.

It seems like it would be a good idea to

  • remove to/from canvas conversions, as WebGL coordinates are setup to represent CSS pixels not device pixels
  • make coordinate transform functions universally return {lat,lng} objects, but accept google.maps.LatLng as well for input parameters.
@dognotdog dognotdog transferred this issue from CMU-CREATE-Lab/esdr Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant