Replies: 5 comments
-
Hi @rob-p, thanks for starting this discussion :) Some arguments in favour of a standalone package:
I think you could also achieve "obviousness" by adding a I don't think I would have time to properly contribute, but I'd be happy to help with testing / giving feedback on documentation 😄 Cheers |
Beta Was this translation helpful? Give feedback.
-
Ah and a couple of thoughts on possible functionality:
|
Beta Was this translation helpful? Give feedback.
-
Re:fishpond. Agree not everything has to go there. Only if it’s useful for the developer. My notes from the other thread: We have some stuff in fishpond for import and processing, and welcome to consider other things to go in there. Just need docs and tests really. There’s even some new stuff for working with EC counts. But it doesn’t have to go there if you want a stand-alone functionality. Recently we took out non-R code to move to a separate package for ease of installation. EDS package on Bioc (Avi’s) now has the original alevin data storage format which is read in with C++. So that’s one consideration: we don’t want extra dependency burden for fishpond. |
Beta Was this translation helpful? Give feedback.
-
Thanks @wmacnair for the overview and suggestions and @mikelove for the thoughts wrt fishpond. I agree that a lot of the functionality described above doesn't make sense to live in fishpond itself. However, I wonder if there is an argument for a new package That is, I'd also like to avoid spreading out / re-writing the R infrastructure for handling the Any thoughts on a package like that? |
Beta Was this translation helpful? Give feedback.
-
Briefly: if you want you can also have a package as a Suggests, which means it is not required for installation but is used for testing. You can therefore have users prompted to install an extra package only when needed. |
Beta Was this translation helpful? Give feedback.
-
This discussion is meant to follow up on the closing post of @wmacnair in #55 (cc @DongzeHE, @mikelove). The relevant part of that post is reproduced below:
However, reading through again it was clear to me that it would be great to have a small, purpose-built standalone R package for loading simpleaf / alevin-fry outputs into R.
At the moment you suggest using fishpond::loadFry. This works fine, but I find it a bit unsatisfying, partly because it's not the main purpose of the package, but also some additional functionality would be great.
For example, I would love to see a package, e.g. simpleafR, that does:
I'd like to gauge interest in this, as well as get feedback on:
Beta Was this translation helpful? Give feedback.
All reactions