-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Salmon 1.1.0 auto update check stalled #486
Comments
The same with version 1.2.0. Is there a way to disable version check by default, completely? I install Salmon as a module and I wouldn't let it update itself automatically, anyway. |
Hi @cihanerkut, First, thanks for reporting this, and going through the trouble to give the However, the most surprising thing is that you are finding the call to the version check ip to be hanging for any significant amount of time. The timeout should be pretty quick. How long does it hang when you do |
Hi @rob-p, The first attempt timed out in 2 min 7 sec.
|
|
I would have prefered an option to check if a new version is available instead of having a software that systematicly phone home it will be problematic on our cluster as compute nodes does not have network acces to internet. regards Eric |
Does passing
or
There should be no network access when using this flag. |
yes on our local installation I disabled the getVersionMessage even if salmon handle the no network cleanly. (I tested using sorry if it it may sound harsh |
Just an idea. Would it be possible to assign an environment variable, such as SALMON_NO_VERSION_CHECK, whose existence overrides version checking? This wouldn't break compatibility with older scripts because they wouldn't have the variable in the first place. In non-networked nodes, an admin can simply set this variable and users will run salmon as usual. |
Yes; this is a nice solution and I think it wouldn't be too hard! |
@cihanerkut and @EricDeveaud, We just released 1.2.1, which is on the release page, and dockerhub, and should propagate to bioconda soon. It adds support for the --Rob |
thanks |
Thank you very much! |
salmon
command gives as expected:However,
salmon index --help
freezes without any CPU usage.strace
shows it's trying to connect to an IP address, which belongs to GitHub but out of commission right now.Waiting long enough, it tries another IP address, which is also broken.
My Salmon is compiled with GCC 8.2.0 / gompi2019a toolset using EasyBuild. It runs on Centos 7.
Passing
--no-version-check
solves the problem but this option isn't displayed on main help screen, I found it somewhere in the source.The text was updated successfully, but these errors were encountered: