-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues related to CI reproducibility test #265
Comments
Yikes, good catch @minghangli-uni. I'm confused about why we're not getting the end-of-run stats in |
I thought I had checked at some point it was possible to fail the repro test, but this makes a lot of sense ! How often are |
The repro test only takes 3 hours, so it won’t produce any entries in the |
I thought (assumed?) |
We can add a check into the model-config-tests that step is non 0 . And we may as well track the step number as an extra field in the checksum file |
Yeah, I haven’t tested it, but setting ENERGYSAVEDAYS=0.125 should work at least for the existing repro check. |
This issue has been mentioned on ACCESS Hive Community Forum. There might be relevant details there: https://forum.access-hive.org.au/t/cosima-twg-meeting-minutes-2025/4067/4 |
The current CI repro test relies on results from https://github.com/ACCESS-NRI/model-config-tests/blob/main/tests/resources/access-om3/output000/ocean.stats and checksum values from https://github.com/ACCESS-NRI/model-config-tests/tree/main/tests/resources/access-om3/checksums.
But the checksum values will always remain the same as long as the ocean grid doesn’t change. This is because the test reads everything from the initial conditions, and the outputs are deterministic based on those conditions, so the test is essentially invalid or will “always pass” even when model behavior has changed.
I suggest a valid check should include metrics from at least Day 2 to capture any divergence.
The text was updated successfully, but these errors were encountered: