Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only include the required tket2 extensions when compiling packages #550

Open
aborgna-q opened this issue Oct 9, 2024 · 1 comment
Open

Only include the required tket2 extensions when compiling packages #550

aborgna-q opened this issue Oct 9, 2024 · 1 comment
Labels
perf Performance issue

Comments

@aborgna-q
Copy link
Collaborator

aborgna-q commented Oct 9, 2024 •
edited
Loading

Currently we bundle all the tket2 extensions in the packages all the time.
We should detect which extensions are actually being used, and only include those.

guppylang/guppylang/module.py

Lines 337 to 343 in 473745f

# TODO: Currently we just include a hardcoded list of extensions. We should
# compute this dynamically from the imported dependencies instead.
#
# The hugr prelude and std_extensions are implicit.
from guppylang.prelude._internal.compiler.quantum import TKET2_EXTENSIONS
extensions = [*TKET2_EXTENSIONS, guppylang.compiler.hugr_extension.EXTENSION]

A related feature would be to only include the required op definitions from each extension, to further reduce the package size.
@aborgna-q aborgna-q mentioned this issue Oct 15, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 15, 2024
@aborgna-q
feat: Emit infallible float→rotation conversions (#560)
74944a7 
Closes #550 

- Updates `tket2` dependency to `>0.4.1`, where we added the
`tket2.rotation.from_halfturns_unchecked` op
- Updates the json extension definitions
- Removes the panicking conditional when converting floats into
rotations for quantum op params.
@aborgna-q
Copy link
Collaborator Author

Closed the wrong PR

@aborgna-q aborgna-q reopened this Oct 16, 2024
@aborgna-q aborgna-q added enhancement New feature or request perf Performance issue and removed enhancement New feature or request labels Oct 16, 2024
ss2165 pushed a commit that referenced this issue Oct 21, 2024
@aborgna-q @ss2165
feat: Emit infallible float→rotation conversions (#560)
4465788 
Closes #550 

- Updates `tket2` dependency to `>0.4.1`, where we added the
`tket2.rotation.from_halfturns_unchecked` op
- Updates the json extension definitions
- Removes the panicking conditional when converting floats into
rotations for quantum op params.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
perf Performance issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aborgna-q