Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Cow from type_row? #1740

Open
aborgna-q opened this issue Dec 4, 2024 · 1 comment
Open

Remove Cow from type_row? #1740

aborgna-q opened this issue Dec 4, 2024 · 1 comment
Labels
perf Performance issue rust Pull requests that update Rust code

Comments

@aborgna-q
Copy link
Collaborator

Now that most optypes cannot be const-constructed anymore (see #1723), we are almost always constructing type rows from vectors.
The only cases where we use the const-constructed type_row! macro now is for empty typerows or rarely when using type_row![Type::UNIT].

The extra overhead of the Cow is probably not worth it anymore. We should try wrapping a Vec directly instead (and benchmarking the changes!).

@aborgna-q aborgna-q added perf Performance issue rust Pull requests that update Rust code labels Dec 4, 2024
@doug-q
Copy link
Collaborator

doug-q commented Dec 11, 2024

sync::Weak::new is const, but I guess we construct everything pointing to the extension nicely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perf Performance issue rust Pull requests that update Rust code
Projects
None yet
Development

No branches or pull requests

2 participants