feat: Update extension pointers in customConsts #1780
Merged
+217
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1780 +/- ##
==========================================
- Coverage 86.69% 86.64% -0.05%
==========================================
Files 186 186
Lines 34035 34145 +110
Branches 30910 31020 +110
==========================================
+ Hits 29506 29586 +80
- Misses 2857 2883 +26
- Partials 1672 1676 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
doug-q
reviewed
Dec 12, 2024
|
There are no array values yet, I covered all things that implement |
doug-q
reviewed
Dec 12, 2024
| @@ -93,6 +94,12 @@ fn resolve_hugr_extensions() { | |||
| // A constant op using the prelude extension. | |||
| module.add_constant(Value::extension(ConstUsize::new(42))); | |||
|
|
|||
| // A constant op using lists of non-prelude types. | |||
| module.add_constant(Value::extension(ListValue::new( | |||
There was a problem hiding this comment.
can you make this a list of list of float? That way we'll get coverage of resolve_typeargs_extensions
doug-q
approved these changes
Dec 12, 2024
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1742.
Adds a (default defined)
update_extensionscall toCustomConstso it can update its internal extensionWeakpointers after loading a serialized hugr.