Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subgraph constructors are not complete #179

Open
acl-cqc opened this issue Jan 21, 2025 · 0 comments
Open

Subgraph constructors are not complete #179

acl-cqc opened this issue Jan 21, 2025 · 0 comments

Comments

@acl-cqc
Copy link
Contributor

acl-cqc commented Jan 21, 2025

Given a graph which both

  • has several connected components (i.e. the nodes can be partitioned into >1 set, such that every edge is between two nodes in the same set)
  • has disconnected ports (with no edges)

Then

  • Subgraph::with_nodes allows choosing any subset of nodes of any subset of the connected components (e.g. all nodes in some components and no nodes in another), but does not allow specifying whether the unconnected ports of any in-subgraph nodes are part of the boundary or not
  • Subgraph::from_boundary allows specifying whether unconnected ports are interior or boundary, but does not allow to specify whether entire connected components (with no unconnected ports) are in the subgraph or not (as this would not affect the boundary) - we somewhat arbitrarily say that the empty boundary means all components, but any edges mean only (parts of) the components containing the edges.

Thus given
n0 -> n1
n2 -> n3

We cannot create the subgraph {n0,n1} nor the subgraph {n2,n3}.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant