Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Install #8

Open
flywire opened this issue Sep 11, 2022 · 2 comments
Open

Windows Install #8

flywire opened this issue Sep 11, 2022 · 2 comments
Labels

Comments

@flywire
Copy link

flywire commented Sep 11, 2022

A few things aren't clear:

  1. Is it a computer or user install?
  2. Why add LibreCAD3 to path? (anyway, WARNING! PATH too long installer unable to modify PATH!)
  3. Is intention to provide prereleae binaries as debug version?
  4. Support for of old version of OpenGL?

The installer file should have a meaningful name.

@flywire
Copy link
Author

flywire commented Sep 11, 2022

Installs as Librecad shortcut, expect LibreCAD3.

2. Why add LibreCAD3 to path?

I note it is optional in the install with no explanation.

Without adding to path it will not start and can't find files which are not on my computer:

  1. VCRUNTIME140D.dll
  2. MSVCP140D.dll
  3. VCRUNTIME140_1D.dll
  4. ucrtbased.dll

I assume these are the debug versions of the dlls. Following installation, the software should run.

@CRiSTiK24
Copy link
Owner

Hi flywire!
The tool that I'm using to create the installer for windows is CPack, which uses NSIS to create it.

  1. I guess both. I haven't done anything for the functionality, but I can check out if there is a way to restrict it if needed.
  2. I will try to see if there is any way to solve the issue, i had the same but thought it was a personal problem since my path is very long.
  3. On the other side the binaries that you mention (VCRUNTIME140D.dll...) are installed by CMake in the same file with:
include(InstallRequiredSystemLibraries)

It automatically tries to add to the package some needed libraries.
4. So this should work in any modern computer, but if using a VM or old system then using the instructions wroten in "Installation" will be needed.
5.Sure, what name would you want, something like "LibreCAD3.exe"?

All the code for Cpack/NSIS should be in the root CMakeLists.txt, here is it:

#Cpack -> NSIS
#General Vars
set(CPACK_PACKAGE_NAME "LibreCAD3")
set(CPACK_PACKAGE_VENDOR "LibreCAD")
set(CPACK_PACKAGE_VERSION_MAJOR "0")
set(CPACK_PACKAGE_VERSION_MINOR "1")
set(CPACK_PACKAGE_VERSION_PATCH "1")
set(CPACK_SOURCE_PACKAGE_FILE_NAME ${CPACK_PACKAGE_NAME}) #name of the install folder
set(CPACK_PACKAGE_DESCRIPTION "LibreCAD is a free Open Source CAD application for Windows, Apple and Linux. Support and documentation are free from our large, dedicated community of users, contributors and developers.")
set(CPACK_PACKAGE_DESCRIPTION_SUMMARY "Open Source 2D-CAD")
set(CPACK_PACKAGE_HOMEPAGE_URL "https://librecad.org/")
set(CPACK_RESOURCE_FILE_LICENSE "${CMAKE_SOURCE_DIR}/LICENSE") 
#NSIS Vars
set(CPACK_NSIS_ENABLE_UNINSTALL_BEFORE_INSTALL "ON")
set(CPACK_NSIS_MODIFY_PATH "ON")
set(CPACK_CREATE_DESKTOP_LINKS "ON")
set(CPACK_NSIS_DISPLAY_NAME ${CPACK_PACKAGE_NAME})
set(CPACK_NSIS_PACKAGE_NAME ${CPACK_PACKAGE_NAME})
set(CPACK_NSIS_HELP_LINK "https://github.com/LibreCAD/LibreCAD_3")
set(CPACK_NSIS_URL_INFO_ABOUT ${CPACK_PACKAGE_HOMEPAGE_URL})
set(CPACK_NSIS_CONTACT "https://librecad.zulipchat.com/login/")
set(CPACK_NSIS_FINISH_TITLE "Thanks for installing LibreCAD 3")
#For the shortcut
set(CPACK_PACKAGE_EXECUTABLES
    "librecad" "Librecad shortcut"
)
set(CPACK_CREATE_DESKTOP_LINKS 
    "librecad"
)
include(CPack)

@CRiSTiK24 CRiSTiK24 added the TODO label Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants