Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #409: Add DS Algo #654

Closed
wants to merge 51 commits into from
Closed

Fix #409: Add DS Algo #654

wants to merge 51 commits into from

Conversation

shriya030
Copy link
Contributor

Explanation

Fixes #409

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR does not break any part of the existing code.
  • The PR creator have carefully read & adher to the contributing guidelines of the project.
  • The PR is made to the branch that's called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • Have you followed the guidelines in the Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same tech?
  • Is your submission is according to the desired pattern ?
  • Have you placed the contents in the Readme.md keeping the sorting order in mind ?
  • Have you placed the contents in the Dictionary.json keeping the sorting order in mind ?

Does you submission include -

  • Category/Type
  • Official Documnetation
  • Best YouTube creators
  • Useful Websites
  • Dedicated Github page
  • Best Courses
  • Ohter Tips / Hacks

shriya030 and others added 30 commits April 23, 2021 15:39
@shriya030
Added C
a78ea09
@shriya030
Added C
9581250
@shriya030
Added C
251899c
@shriya030
Added C
9767b1b
@shriya030
Added C
0528c20
@shriya030
Merge remote-tracking branch 'upstream/develop' into develop
22dca28
@shriya030
Merge remote-tracking branch 'upstream/develop' into develop
0f42d59
@shriya030
Merge remote-tracking branch 'upstream/develop' into develop
3035887
@shriya030
Merge remote-tracking branch 'upstream/develop' into develop
5629fe3
@shriya030
Added PyQt
609abc8
@shriya030
Added PyQt
17bc331
@shriya030
Added PyQt
b3a78f2
@shriya030
Merge remote-tracking branch 'upstream/develop' into develop
2c6f23b
@shriya030
Corrected Readme.md
aed4571
@shriya030
Edited Readme
4af2c64
@shriya030
Added Socket.io
2da54eb
@shriya030
Added Socket.io
0cf1b23
@shriya030
Update README.md
aa8febc
@shriya030
Merge remote-tracking branch 'upstream/develop' into develop
bf3cec4
@shriya030
Added Turtle
42882d3
@shriya030
Added Turtle
be9cebe
@shriya030
Merge branch 'develop' of https://github.com/CSwala/awesome-computer-…
c724249 
…science into develop
@shriya030
Merge branch 'develop' of https://github.com/CSwala/awesome-computer-…
f44ea7a 
…science into develop
@shriya030
Added WebRTC
265b30f
@shriya030
Added WebRTC
0280ebc
@shriya030
Merge branch 'develop' of https://github.com/CSwala/awesome-computer-…
618bc23 
…science into develop
@shriya030
Merge branch 'develop' of https://github.com/CSwala/awesome-computer-…
2e4276b 
…science into develop
@shriya030
Added Adobe Photoshop
d8e804e
@shriya030
Added Adobe Photoshop
b1d2010
@shriya030
Added Adobe Photoshop
fbeb742
@ddvader44
Copy link
Member

Resolve Conflicts

@ddvader44 ddvader44 added gssoc21 Level1 Good for newcomers labels Jun 1, 2021
@shriya030
Copy link
Contributor Author

Resolve Conflicts

Done!

@ddvader44
Copy link
Member

The simplest way would be to fetch the current dictionary.json and then adding your content to it

@shriya030
Copy link
Contributor Author

The simplest way would be to fetch the current dictionary.json and then adding your content to it

I did that and it's done!

riturajjain2000
riturajjain2000 requested changes Jun 1, 2021
View reviewed changes
Copy link
Member

@riturajjain2000 riturajjain2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cant review the dictionary file as around 9k lines are added and 9k are deleted , pls see to it and make sure that only the additions are there

@shriya030
Copy link
Contributor Author

Cant review the dictionary file as around 9k lines are added and 9k are deleted , pls see to it and make sure that only the additions are there

How should I do that?

@riturajjain2000
Copy link
Member

Cant review the dictionary file as around 9k lines are added and 9k are deleted , pls see to it and make sure that only the additions are there

How should I do that?

I'll suggest use Github Desktop , so that you can see the changes clearly , and then puch the new commit using it only

@shriya030
Revert "Changes"
42863e5 
This reverts commit 550e8bd, reversing
changes made to fcb0da2.
@shriya030 shriya030 closed this Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riturajjain2000 riturajjain2000 riturajjain2000 requested changes

Assignees
No one assigned
Labels
gssoc21 Level1 Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add DS Algo
3 participants
@shriya030 @ddvader44 @riturajjain2000