Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional List Styles should be an optional feature #249

Open
portalzine opened this issue Feb 11, 2020 · 2 comments
Open

Additional List Styles should be an optional feature #249

portalzine opened this issue Feb 11, 2020 · 2 comments

Comments

@portalzine
Copy link

Really love what you are doing, but all additional block styles and options should be optional. You did a great job for most of the additional features.

But I had to manually do unregisterBlockStyles for the core/list to clean up the styles that are not wanted.

Keep up the great work.
Alex

@phpbits
Copy link
Collaborator

phpbits commented Feb 11, 2020

Thanks a lot for the suggestion @portalzine! I'll add the list style on the features manager in order to make it easily removable.

@Log1x
Copy link

Log1x commented Mar 15, 2020

I'd also like to request that styles such as the list are not compiled in the main stylesheet and can be dequeued. With the style classnames being so generic with no scoping, it ruins the ability to apply your own styles to a generic style name such as .is-style-checked – even when the EditorsKit block styles themselves are unregistered.

I realize this is a nitpick and the easy solution is to simply use another class name – but I do think something like this should play a bit more nice / be controllable without turning into a style specificity war or who named what first in your Gutenberg toolkit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants