Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] - Adding different type of Exception for crop cancel. #332

Closed
rempawl opened this issue Mar 14, 2022 · 2 comments · Fixed by #344
Closed

[Feat] - Adding different type of Exception for crop cancel. #332

rempawl opened this issue Mar 14, 2022 · 2 comments · Fixed by #344

Comments

@rempawl
Copy link
Contributor

rempawl commented Mar 14, 2022

Is it possible to add some CropCancellationException instead Exception(msg) here?

 object CancelledResult : CropImageView.CropResult(
        originalBitmap = null,
        originalUri = null,
        bitmap = null,
        uriContent = null,
        error = Exception("cropping has been cancelled by the user"),
        cropPoints = floatArrayOf(),
        cropRect = null,
        wholeImageRect = null,
        rotation = 0,
        sampleSize = 0
    )

then it would be more convenient to differentiate it from other exceptions using is operator instead ==

@Canato
Copy link
Member

Canato commented Mar 15, 2022

Good suggestion. Yeah free to people to create a CropException class so we can use in our Exceptions.

Feel free to drop a PR or let's see if someone will get this

@stale
Copy link

stale bot commented Mar 30, 2022

Let's keep this mess organised! This issue has been automatically marked as stale because it has not had recent activity. =( It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 30, 2022
@rempawl rempawl mentioned this issue Mar 31, 2022
4 tasks
@Canato Canato mentioned this issue Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants