Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] - CropImageView has no way of setting a CropImageOptions programmatically #397

Closed
vanniktech opened this issue Jun 25, 2022 · 2 comments

Comments

@vanniktech
Copy link
Contributor

Currently, it's constructed via XML attributes, however when using that View programmatically there's no real way to pass in a CropImageOptions to configure it

I wanted to use #390 only to realize that there's no way for me to actually use it.

Maybe the options would also need to be splitted since CropImageView calls into CropOverlayView which calls into CropWindowHandler and they are all sharing the same options. Seems like each should have their own.

@Canato
Copy link
Member

Canato commented Jun 28, 2022

I like the idea, let's see how would be implemented on the sample app 👍

@stale
Copy link

stale bot commented Jul 13, 2022

Let's keep this mess organised! This issue has been automatically marked as stale because it has not had recent activity. =( It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 13, 2022
@stale stale bot closed this as completed Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants