Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enrollmentDate, tweak example app UI, fix typos #12

Merged
merged 1 commit into from
Jun 25, 2021

Conversation

mmertsock
Copy link
Member

Closes #11. The only SDK change here is adding enrollmentDate to ParticipantInfo. The other changes are all in the example app.

The string "MyDataHelpsKit vX.X.X" in the example app nav bar title was too long and getting truncated, so I moved it to a heading-style label in TokenView (the first view displayed when launching the app).

@eschramm
Copy link

eschramm commented Jun 25, 2021

LGTM. It's a shame we have to keep enrollmentDate an Optional here because I can't think of a use case here where you could interact with a non-enrolled participant in our standard RKStudio projects.

@mmertsock mmertsock merged commit d1cfb46 into main Jun 25, 2021
@mmertsock mmertsock deleted the mmertsock/enrollment-date branch June 25, 2021 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add enrollmentDate to ParticipantInfo
2 participants