Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scabbard client does not return error_data returned in InvalidTransaction error #503

Open
arsulegai opened this issue Feb 9, 2020 · 3 comments

Comments

@arsulegai
Copy link
Contributor

The error_data is always empty [] when using the scabbard exec command. One has to peep into the Splinter daemon logs to know what is printed by the smart contract. The log captured by this client is from the [consensus::consensus::two_phase] when looked into the Splinter daemon logs.

@peterschwarz
Copy link
Contributor

peterschwarz commented Feb 10, 2020

Sabre transactions don't yet return the error data from the handler. The exports in the to the WASM runtime need to be updated to support this.

In other words, this is more of a Sabre bug than a splinter bug.

@arsulegai
Copy link
Contributor Author

Sabre transactions don't yet return the error data from the handler. The exports in the to the WASM runtime need to be updated to support this.

In other words, this is more of a Sabre bug than a splinter bug.

When I say error_data, my expectation was to see the message that is put in InvalidTransaction. Are we on same page with this understanding?

@peterschwarz
Copy link
Contributor

Yes, I believe so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants