Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browsers support #1994

Closed
ivanmalagon opened this issue Dec 28, 2017 · 14 comments
Closed

Browsers support #1994

ivanmalagon opened this issue Dec 28, 2017 · 14 comments
Labels

Comments

@ivanmalagon
Copy link
Contributor

ivanmalagon commented Dec 28, 2017

As suggested by a customer in https://carto.com/documentation/cartojs/support/browsers/ we should state that carto.js it's suitable for mobile browsers as well.

Previous to that we need to check that they work, of course.

Adding to this issue:

  • We need to add a row to https://carto.com/developers/carto-js/support/browser-support/ for most used mobile browsers (as Iago says below).
  • Modify the desktop table to say Edge instead of IE, add an entry for IE11 and rewrite the first sentence as CARTO.js works for the last 2 versions in any modern browser and IE11
@ivanmalagon
Copy link
Contributor Author

Waiting for customer's feedback.

@IagoLast
Copy link
Contributor

I started to play with https://testobject.com to test this map in order to do some real device testing.

  • iPhone 5: IOS 10.0.2
    iphone 5 free - ios 10 0 2

  • Motorola MotoE: Android 6.0, Chrome 63.0.3239.111
    2018-01-15 16_27_29 - motorola moto e 2nd gen - android 6 0

@IagoLast
Copy link
Contributor

IagoLast commented Jan 15, 2018

Regarding to this issue I see the following steps:

  1. Write a list with the most used mobile browsers (maybe from here?)
  2. Decide the supported mobile browsers
  3. Manually test those browsers
  4. Update docs according to this process

@ivanmalagon
Copy link
Contributor Author

Is it possible to test interaction? (The problem reported by the customer that triggered this issue)

@IagoLast
Copy link
Contributor

Is it possible to test interaction

yep, both devices had popups working :D

@ivanmalagon ivanmalagon changed the title Mobile browsers support Browsers support Jul 6, 2018
@jesusbotella
Copy link
Contributor

I think we can use most of the ones that CanIUse have in their page: iOS Safari, Chrome for Android, and Samsung Internet. And maybe Opera Mini and UC Browser for Android, but I don't know if would put that ones.

@rubenmoya
Copy link
Contributor

Would you add Firefox for Android?

@rubenmoya
Copy link
Contributor

rubenmoya commented Jul 11, 2018

Mobile from 07-2017 to 06-2018  Mobile just 2018
screen shot 2018-07-11 at 09 48 22 screen shot 2018-07-11 at 09 48 37
Tablet from 07-2017 to 06-2018  Tablet just 2018
screen shot 2018-07-11 at 09 40 15 screen shot 2018-07-11 at 09 39 49

@ivanmalagon
Copy link
Contributor Author

Let's check it in

  • Chrome
  • Safari
  • Android browser
  • UC Browser

@IagoLast
Copy link
Contributor

mobile only?

@ivanmalagon
Copy link
Contributor Author

This issue is about mobile, yes.

@jesusbotella
Copy link
Contributor

I have checked the examples in Chrome for Android, iOS Safari, and Android browser and work flawlessly.

In Android Browser, CARTO.js itself works but the examples are not being shown properly due to the ES6 code in the examples. I don't know if we want to fix that 🤷‍♂️.

I'll test UC Browser at home with an Android phone capable of supporting it.

@ivanmalagon
Copy link
Contributor Author

These are the main browsers in our GA for embeds. I think we're good to extrapolate that this is a very representative image of our users.

Let's take care of these ones.

image

@ivanmalagon
Copy link
Contributor Author

This was done at #2168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants