Improve legend error #1758
Merged
Improve legend error #1758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
September 18, 2017 11:37
elenatorro
reviewed
Sep 19, 2017
| this.$el.hide(); | ||
| } | ||
| this.model.isVisible() | ||
| ? this.$el.show() |
There was a problem hiding this comment.
Or this.$el.toggle(this.model.isVisible()) but I prefer the way you implemented.
There was a problem hiding this comment.
@nobuti comment is the winner, IMHO 💃 .
nobuti
reviewed
Sep 19, 2017
|
|
||
| var placeholder = this._getPlaceholderHTML(); | ||
|
|
||
| var error = this.model.isError() |
There was a problem hiding this comment.
What a fail 😓 let me change it
nobuti
approved these changes
Sep 22, 2017
|
Could we prepare it for the acceptance? I guess we will need a builder branch, right? |
|
Builder branch created! |
|
Deployed to |
|
Tested and working 👌 , merging guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #1715
The goal was to add an error message related to limits. After some research we realized we can't have limits errors here since the legends come from
viz.json, it could only fail when instantiating the map or when parsing CartoCSS, and we're already covered.The only change introduced by this PR is changing the
No data availablestyles and refactor thelegend-view-base.js.Acceptance
To show the "Something went wrong" text:
To show the "No data available" text: