You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, I am scanning the pelite in the latest version with my own static analyzer tool.
Unsafe conversion found at: src/pe64/view.rs#L84
#[inline]pubunsafefnmodule(base:*constu8) -> PeView<'a>{let dos = &*(base as*constIMAGE_DOS_HEADER);let nt = &*(base.offset(dos.e_lfanewasisize)as*constIMAGE_NT_HEADERS);PeView{image: slice::from_raw_parts(base, nt.OptionalHeader.SizeOfImageasusize),base_address: base asVa,}}
This unsound implementation would create a misalignment issues if the type size of u8 is smaller than the type size of IMAGE_DOS_HEADER.
This would potentially cause undefined behaviors in Rust. If we further manipulate the problematic converted types, it would potentially lead to different consequences such as access out-of-bound. I am reporting this issue for your attention.
The text was updated successfully, but these errors were encountered:
Hi, I am scanning the pelite in the latest version with my own static analyzer tool.
Unsafe conversion found at: src/pe64/view.rs#L84
This unsound implementation would create a misalignment issues if the type size of
u8
is smaller than the type size ofIMAGE_DOS_HEADER
.This would potentially cause undefined behaviors in Rust. If we further manipulate the problematic converted types, it would potentially lead to different consequences such as access out-of-bound. I am reporting this issue for your attention.
The text was updated successfully, but these errors were encountered: