Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move getChangedFile into LinchpinPipelineUtils.groovy #693

Closed
herlo opened this issue Sep 17, 2018 · 3 comments · Fixed by #1098
Closed

Move getChangedFile into LinchpinPipelineUtils.groovy #693

herlo opened this issue Sep 17, 2018 · 3 comments · Fixed by #1098
Assignees
@samvarankashyap
Labels
ci improvement ci restructure ci jenkins low priority

Comments

@herlo
Copy link
Contributor

herlo commented Sep 17, 2018

In the recent updates to the merge and release process, a new function was introduced in [JenkinsfileGHPRMerge]https://github.com/CentOS-PaaS-SIG/linchpin/blob/develop/config/Dockerfiles/JenkinsfileGHPRMerge#L159).

It was recommended in PR #685 to move this into LinchpinPipelineUtils.groovy and refactor the getTargetsToTest method also. This ticket is here to track that work.
@herlo herlo added the ci label Sep 17, 2018
@adl-bot adl-bot mentioned this issue Dec 13, 2018
Merged
@samvarankashyap
Copy link
Contributor

@p3ck Any thoughts ?

@p3ck
Copy link
Contributor

p3ck commented Apr 9, 2019

agreed - it should be moved into the linchpin library.

@samvarankashyap samvarankashyap mentioned this issue Apr 18, 2019
Merged
@samvarankashyap samvarankashyap added this to the v1.7.6 milestone Jun 4, 2019
@samvarankashyap samvarankashyap self-assigned this Jun 11, 2019
@samvarankashyap samvarankashyap modified the milestones: v1.7.6, v2.0 Jul 11, 2019
@samvarankashyap
Copy link
Contributor

Closing this issue in favor of #1223

@samvarankashyap samvarankashyap removed this from the v2.0.0 milestone Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samvarankashyap samvarankashyap

Labels
ci improvement ci restructure ci jenkins low priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move getChangedFile function to utils samvarankashyap/linchpin
3 participants
@herlo @p3ck @samvarankashyap