Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider pinning the Node version to a specific number #93

Open
javagl opened this issue Jan 27, 2024 · 0 comments
Open

Consider pinning the Node version to a specific number #93

javagl opened this issue Jan 27, 2024 · 0 comments

Comments

@javagl
Copy link
Contributor

javagl commented Jan 27, 2024

Right now, the package.json specifies

"engines": {
  "node": ">=16.0.0"
},

There might be benefits in being more specific. The exact node version could be specified in an .nvmrc file, which could also be picked up by the CI script. I'm a bit on the fence here: On the one hand, it could avoid random build failures that are caused by random changes in some Node version. On the other hand, it should be possible to compile and run the tools on every Node version (>=16), and if there is an issue with one version, then this should be detected and fixed.

The implications for users/contributors also have to be investigated. (E.g. would pinning the version to 20.10 mean that someone couldn't even compile it without having this exact version?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant