-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeError on setting the Viewer selectedEntity #12303
Comments
Definitely a regression from the Viewer > Widget changes. I was only able to reproduce with some types of entities but will look into it further. Sandcastle reproducing the issue |
Thank you for narrowing this down @jfayot! Please feel free to open a PR with a fix if you manage to track it down. |
No idea at first sight. May be you could ask to the author of this PR #12230 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened?
After updating CesiumJS to version 1.123.1, an error is being thrown during rendering causing rendering to stop. This also happens in v1.123.0.
When updating the value of Viewer.selectedEntity, assigning it an Entity object that has been added to the Viewer, the above error is shown. This is running in a Vue 3 app.
The error is fixed by disabling any calls of setting the Viewer.selectedEntity property. No errors are thrown when the property is retrieved. We have reverted back to v1.122.0 for the meanwhile to allow us to update the selectedEntity property.
This was not causing errors in previous versions, but do we need to wait until rendering is complete before setting the selectedEntity property?
Reproduction steps
Sandcastle example
No response
Environment
Browser: Firefox 132.0.1
CesiumJS Version: 1.123.1
Operating System: Ubuntu 22.04
The text was updated successfully, but these errors were encountered: