Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation contains broken links to private members #4001

Closed
hpinkos opened this issue Jun 6, 2016 · 3 comments
Closed

Documentation contains broken links to private members #4001

hpinkos opened this issue Jun 6, 2016 · 3 comments
Labels
category - doc good first issue An opportunity for first time contributors

Comments

@hpinkos
Copy link
Contributor

hpinkos commented Jun 6, 2016

For example, ShadowMap contains a link to Context

Clicking this goes to an 'access denied' page.

@lilleyse
Copy link
Contributor

lilleyse commented Jun 6, 2016

Ah I forgot about that. One solution is to pass Scene to ShadowMap instead of Context. The other is to initialize values on the first frame of the update loop with the frame states's context.

@hpinkos
Copy link
Contributor Author

hpinkos commented Jun 6, 2016

@lilleyse there aren't any changes you should have to make to your code. jsDoc should know not to make a link for something that's not there.

@pjcozzi pjcozzi added the good first issue An opportunity for first time contributors label Dec 20, 2016
@pjcozzi
Copy link
Contributor

pjcozzi commented Jan 2, 2017

Duplicate with #4010.

@pjcozzi pjcozzi closed this as completed Jan 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category - doc good first issue An opportunity for first time contributors
Projects
None yet
Development

No branches or pull requests

3 participants