You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Our pinBuilder helper produces pins that can have low-alpha "fringes" on the interior of the pin. For example, here's the Maki shopping cart on a pin, shown alongside a greyscale version of its alpha map:
Here's a question mark on a pin, alongside its alpha map:
In the alpha map images above, the white pin body should NOT have any black pixels floating around in it. Both of them do, although the shopping cart one is much more subtle, the question mark one is more obvious.
I've tested as far back as Cesium 1.20 and the pinBuilder appears to have this problem even back then. It wasn't much of an issue until now, with the billboard blending fixes coming in, the low alpha values are actually leaking other billboards through them.
The inset image written onto the pin should of course use the alpha values for proper blending, but it should use those values to blend against the pin's background color, not against a transparent background. The resulting pixels should always have exactly the pin background's opacity.
The text was updated successfully, but these errors were encountered:
@emackey this is probably a one line change in PinBuilder's drawIcon function. I assume we are putting the canvas in an incorrect compositing mode or something. Might be a super easy fix if you want to take a look.
Noticed in #5066.
Our pinBuilder helper produces pins that can have low-alpha "fringes" on the interior of the pin. For example, here's the Maki shopping cart on a pin, shown alongside a greyscale version of its alpha map:
Here's a question mark on a pin, alongside its alpha map:
In the alpha map images above, the white pin body should NOT have any black pixels floating around in it. Both of them do, although the shopping cart one is much more subtle, the question mark one is more obvious.
I've tested as far back as Cesium 1.20 and the pinBuilder appears to have this problem even back then. It wasn't much of an issue until now, with the billboard blending fixes coming in, the low alpha values are actually leaking other billboards through them.
The inset image written onto the pin should of course use the alpha values for proper blending, but it should use those values to blend against the pin's background color, not against a transparent background. The resulting pixels should always have exactly the pin background's opacity.
The text was updated successfully, but these errors were encountered: