Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rectanglePromise.then is not a function #11392

Merged
merged 3 commits into from
Jul 5, 2023
Merged

fix: rectanglePromise.then is not a function #11392

merged 3 commits into from
Jul 5, 2023

Conversation

hongfaqiu
Copy link
Contributor

In the latest Cesium version, v1.107.0, an issue has occurred when using viewer.flyTo to navigate to an ImageryLayer.

@cesium-concierge
Copy link

Thanks for the pull request @hongfaqiu!

  • ❌ Missing CLA.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.

@hongfaqiu
Copy link
Contributor Author

Thanks for the pull request @hongfaqiu!

  • ❌ Missing CLA.

  • CHANGES.md was not updated.

    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.

    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.

CLA sended

@ggetz
Copy link
Contributor

ggetz commented Jul 5, 2023

Thank you @hongfaqiu! Could you please update CHANGES.md with a summary of the fix?

@hongfaqiu hongfaqiu closed this Jul 5, 2023
@hongfaqiu hongfaqiu reopened this Jul 5, 2023
@hongfaqiu
Copy link
Contributor Author

@ggetz Thank you for reviewing! I wrote the fix summary in the 'Fixes 🔧' column of version 1.107. I'm not sure if this is the correct way to do it.

@ggetz
Copy link
Contributor

ggetz commented Jul 5, 2023

Thanks again @hongfaqiu ! I moved your change to the next release.

I also noticed that we didn't have a unit test to cover this case. I went ahead and added one. This should be good to merge in as soon as CI passes.

@ggetz ggetz merged commit ddfc7eb into CesiumGS:main Jul 5, 2023
@hongfaqiu
Copy link
Contributor Author

Thanks again @ggetz! I am delighted to be one of the contributors to this great project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants