Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create World Bathymetry helper function #11795

Merged
merged 6 commits into from
Jan 31, 2024
Merged

Create World Bathymetry helper function #11795

merged 6 commits into from
Jan 31, 2024

Conversation

jjspace
Copy link
Contributor

@jjspace jjspace commented Jan 29, 2024 •
edited by ggetz
Loading

Description

Creates a helper function to easily load the CWB terrain like you can with CWT. createWorldBathymetryAsync was added and Terrain.fromWorldBathymetry included as an additional way to access matching the CWT functions

I also added a new sandcastle to show off the capabilities of bathymetry (thanks @ggetz for making that)

Issue number and link

Fixes #11790

Testing plan

  • Open the new sandcastle locally and make sure it works
  • Also test the Terrain.fromWorldBathymetry function in the same or a fresh sandcastle or click this one

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have update the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

@jjspace jjspace requested a review from ggetz January 29, 2024 22:06
ggetz
ggetz reviewed Jan 30, 2024
View reviewed changes
Copy link
Contributor

@ggetz ggetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @jjspace!

CHANGES.md Outdated Show resolved Hide resolved
packages/engine/Source/Core/createWorldBathymetryAsync.js Outdated Show resolved Hide resolved
packages/engine/Source/Core/createWorldTerrainAsync.js Outdated Show resolved Hide resolved
packages/engine/Source/Scene/Terrain.js Outdated Show resolved Hide resolved
packages/engine/Source/Scene/Terrain.js Outdated Show resolved Hide resolved
packages/engine/Source/Core/createWorldBathymetryAsync.js Outdated Show resolved Hide resolved
packages/engine/Source/Scene/Terrain.js Outdated Show resolved Hide resolved
packages/engine/Source/Scene/Terrain.js Outdated Show resolved Hide resolved
packages/engine/Source/Scene/Terrain.js Outdated Show resolved Hide resolved
@jjspace
Copy link
Contributor Author

jjspace commented Jan 30, 2024

@ggetz All comments addressed

@ggetz
Copy link
Contributor

ggetz commented Jan 30, 2024

Thanks @jjspace, other than that one comment, this is looking good!

@ggetz
Copy link
Contributor

ggetz commented Jan 31, 2024

Thanks again @jjspace!

@ggetz ggetz merged commit 1ece49a into main Jan 31, 2024
9 checks passed
@ggetz ggetz deleted the create-world-bathymetry branch January 31, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggetz ggetz ggetz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a helper function and Sandcastle example for CWB
2 participants
@jjspace @ggetz