Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle undefined Primitives bounding spheres. #4402

Closed

Conversation

dwhipps
Copy link
Contributor

@dwhipps dwhipps commented Oct 4, 2016

I found that I would often get undefined bounding spheres here (with some KML data sets, if that helps).

I'm not actually sure whether it's better to not set these "batchedAttribute"(s) (as I do here) or to set them to some default value (zeros, for example.)

@hpinkos
Copy link
Contributor

hpinkos commented Oct 4, 2016

I don't know exactly what's going on, but I feel like it's a problem if the bounding sphere is undefined. @bagnell do you have any idea?

@dwhipps, could you attach a KML that reproduces the problem? Thanks!

@mramato
Copy link
Contributor

mramato commented Oct 5, 2016

Thanks @dwhipps, I agree with @hpinkos that this looks more like a symptom of a bigger problem. If you can share one of the KML files or a simple test case, that would be a big help.

@bagnell
Copy link
Contributor

bagnell commented Oct 5, 2016

The bounding sphere should always be defined. Unless the code doesn't handle invalid geometry correctly, for example, a degenerate polygon. I ran some tests, but I couldn't reproduce the crash.

@dwhipps
Copy link
Contributor Author

dwhipps commented Oct 6, 2016

Sorry, I've been on another project for a few days. Just getting bach to this now. I'll try to put together a Sandcastle showing the problem.

@mramato
Copy link
Contributor

mramato commented Oct 26, 2016

@dwhipps I'm assuming you are running into the same problem as #4431, which includes a KML that reproduces the issue. We fixed the initial problem but now there are lots of undefined bounding spheres compared to 1.25 where everything works.

@mramato
Copy link
Contributor

mramato commented Oct 27, 2016

@dwhipps this was fixed with #4532

The only time you should have undefined bounding spheres is if the geometry failed to be created (for example polygons with invalid data or that fail to triangulate). We handled these gracefully in the past, but a regression in 1.26 caused issues. See the linked PR for details. Thanks for helping bring the issue to our attention and if you're still having problems, let us know.

@mramato mramato closed this Oct 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants