Fix updateBatchTableBoundingSpheres

[mramato]

updateBatchTableBoundingSpheres was using the BoundingSphere center without applying the modelMatrix to the sphere first.

Fixes #4431 and #4428

@bagnell as discussed offline, this may not be the most correct fix, but let me know what you think. We probably want a unit test for this as well.

[hpinkos]

Just waiting on unit tests. @mramato let me know when this is ready =)

[hpinkos]

#4428 is fixed, but I'm still getting a crash with the KML file included in #4431

DeveloperError: sphere is required.
Error
    at new DeveloperError (http://localhost:8080/Source/Core/DeveloperError.js:44:19)
    at Function.BoundingSphere.transform (http://localhost:8080/Source/Core/BoundingSphere.js:1003:19)
    at updateBatchTableBoundingSpheres (http://localhost:8080/Source/Scene/Primitive.js:1197:45)

[mramato]

I'm still working on this, so there's a chance that I'll fix it or it's a completely different unrelated crash.

[hpinkos]

alright, let me know when this is ready then

[mramato]

This is ready. I'm going to open a PR for #4431 separately since fixing the first issue exposes a new one.

[hpinkos]

@pjcozzi can you take a quick look at this and merge it? It fixes the problem, I'm just not 100% sure on the code changes.

[pjcozzi]

Why not

var modelMatrix = primitive.modelMatrix;
if (defined(modelMatrix)) {
   boundingSphere = BoundingSphere.transform(boundingSphere, modelMatrix, boundingSphere);
}

[pjcozzi]

Just that comment.

Also, update CHANGES.md

[mramato]

Thanks @pjcozzi, good call. Both are done.

[pjcozzi]

#4428 is fixed.

With #4431, I get this on drag and drop:

[mramato]

With #4431, I get this on drag and drop:

Yes, we discussed this earlier in the PR: #4461 (comment)

[pjcozzi]

Sounds good.