Add ability to specify Bing Maps geocoder culture #9729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request @mramato!
Reviewers, don't forget to make sure that:
|
mramato
force-pushed
the
karma-chameleon
branch
from
7949c5b
to
5fa8b05
Compare
1. Add optional `culture` property to BingMapsGeocoderService constructor and use it to set culture when making a request. This causes the results to be displayed in the specified culture and language. 2. Update Resource.js to use CesiumMath's RNG so we can have a random seed with consistent results 3. Slightly improve BingMapsGeocoderService tests to support the new functionality and double check some existing code.
mramato
force-pushed
the
karma-chameleon
branch
from
5fa8b05
to
830d2c3
Compare
|
Thanks @mramato! I confirmed this works in Sandcaslte and that specs pass. The code changes look good to me. I pushed a fix to the link in the new docs but otherwise this is good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add optional
cultureproperty to BingMapsGeocoderService constructor and use it to set culture when making a request. This causes the results to be displayed in the specified culture and language.Update Resource.js to use CesiumMath's RNG so we can have a random seed with consistent results
Slightly improve BingMapsGeocoderService tests to support the new functionality and double check some existing code.