From 4a3156d9d02ee7a1b10bc1289e7ef172790ad720 Mon Sep 17 00:00:00 2001 From: vtxf Date: Fri, 15 Oct 2021 17:51:16 +0800 Subject: [PATCH 1/3] fix the bug of ktx2's texture minfilter --- CHANGES.md | 6 ++++++ CONTRIBUTORS.md | 2 ++ Source/Scene/Model.js | 2 +- 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/CHANGES.md b/CHANGES.md index 4fecfc3af3c6..d756e92c801e 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -1,5 +1,11 @@ # Change Log +### 1.88 - 2021-12-1 +##### Fixes :wrench: + +- fix the bug of ktx2 texture minfilter. + + ### 1.87 - 2021-11-1 ##### Additions :tada: diff --git a/CONTRIBUTORS.md b/CONTRIBUTORS.md index c3322746d509..08d52d46e143 100644 --- a/CONTRIBUTORS.md +++ b/CONTRIBUTORS.md @@ -168,6 +168,8 @@ See [CONTRIBUTING.md](CONTRIBUTING.md) for details on how to contribute to Cesiu - [Mark Aubin](https://github.com/markaubin) - [Michael Shantzis](https://github.com/shantzis1962) - [Sebastian Fernandez](https://github.com/SebastianPFernandez) +- [Beijing Xibushijie] + - [Tang Xiaofei](https://github.com/vtxf) ## [Individual CLA](Documentation/Contributors/CLAs/individual-contributor-license-agreement-v1.0.pdf) diff --git a/Source/Scene/Model.js b/Source/Scene/Model.js index 4d39a5375866..1271089c7040 100644 --- a/Source/Scene/Model.js +++ b/Source/Scene/Model.js @@ -2934,7 +2934,7 @@ function createTexture(gltfTexture, model, context) { ); } - var minificationFilter; + var minificationFilter = sampler.minificationFilter; if ( !defined(gltfTexture.mipLevels) && (minFilter === TextureMinificationFilter.NEAREST_MIPMAP_NEAREST || From 61673ceef5716dab59643249aa54ccd7a9a8b10d Mon Sep 17 00:00:00 2001 From: Tang Xiaofei Date: Sat, 6 Nov 2021 13:43:01 +0800 Subject: [PATCH 2/3] Update CHANGES.md Co-authored-by: Eli Bogomolny <31491650+ebogo1@users.noreply.github.com> --- CHANGES.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGES.md b/CHANGES.md index d756e92c801e..ddfb0b58de56 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -1,10 +1,10 @@ # Change Log ### 1.88 - 2021-12-1 -##### Fixes :wrench: -- fix the bug of ktx2 texture minfilter. +##### Fixes :wrench: +- Fixed a bug with .ktx2 textures having an incorrect minification filter. [#9876](https://github.com/CesiumGS/cesium/pull/9876/) ### 1.87 - 2021-11-1 From 5da8b47a8f288db4264329ddcda6dd7168a1102d Mon Sep 17 00:00:00 2001 From: Tang Xiaofei Date: Sat, 6 Nov 2021 13:44:22 +0800 Subject: [PATCH 3/3] Update CONTRIBUTORS.md Co-authored-by: Eli Bogomolny <31491650+ebogo1@users.noreply.github.com> --- CONTRIBUTORS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTORS.md b/CONTRIBUTORS.md index 08d52d46e143..457179a3e766 100644 --- a/CONTRIBUTORS.md +++ b/CONTRIBUTORS.md @@ -168,7 +168,7 @@ See [CONTRIBUTING.md](CONTRIBUTING.md) for details on how to contribute to Cesiu - [Mark Aubin](https://github.com/markaubin) - [Michael Shantzis](https://github.com/shantzis1962) - [Sebastian Fernandez](https://github.com/SebastianPFernandez) -- [Beijing Xibushijie] +- Beijing Xibushijie - [Tang Xiaofei](https://github.com/vtxf) ## [Individual CLA](Documentation/Contributors/CLAs/individual-contributor-license-agreement-v1.0.pdf)